Configure ring buffer depth at build time - #625
Closed
Molter73 wants to merge 1 commit into
Closed
Conversation
Molter73
marked this pull request as draft
March 24, 2022 10:37
5 tasks
Stringy
force-pushed
the
giles/ROX-9409-setting-probe-name-and-probe-version
branch
from
March 24, 2022 14:33
0c907d0 to
ef3281b
Compare
Molter73
force-pushed
the
mauro/ROX-9418-allow-ringbuffer-depth-config
branch
2 times, most recently
from
March 25, 2022 09:00
d6bd6fd to
7c1d538
Compare
Stringy
force-pushed
the
giles/ROX-9409-setting-probe-name-and-probe-version
branch
2 times, most recently
from
May 6, 2022 10:51
62b83d4 to
fb11b76
Compare
Stringy
force-pushed
the
giles/ROX-9409-setting-probe-name-and-probe-version
branch
2 times, most recently
from
May 12, 2022 15:33
be07b16 to
e731220
Compare
Stringy
force-pushed
the
giles/ROX-9409-setting-probe-name-and-probe-version
branch
from
May 25, 2022 09:12
e731220 to
1148f80
Compare
Base automatically changed from
giles/ROX-9409-setting-probe-name-and-probe-version
to
master
May 30, 2022 07:20
Molter73
force-pushed
the
mauro/ROX-9418-allow-ringbuffer-depth-config
branch
from
May 30, 2022 13:05
7c1d538 to
2c51dc3
Compare
|
@Molter73: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Molter73: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Member
Author
|
This PR is outdated, #1343 will already enable this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR leverages stackrox/falcosecurity-libs#11, which makes it possible for us to configure the desired ring buffer depth when compiling the collector userspace component and drivers. Right now the depth is set in 2 separate places, we might want to refactor our build system to make it possible to configure both the userspace and driver builds from the same point in the repo.
Merge order for the PR:
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed